Skip to content

Apply changes from meko:mck-merge as single commit #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2025
Merged

Conversation

nammn
Copy link
Collaborator

@nammn nammn commented Apr 22, 2025

Summary

  • done by doing the following on the new branch:

    • git diff meko/master..meko/mck-merge > /tmp/changes.patch
    • rm mongodb-community-operator
    • git apply /tmp/changes.patch
  • with this the missing change-set between meko/mck-merge and mck/mck-merge should align

Proof of Work

  • green ci

Checklist

  • Have you linked a jira ticket and/or is the ticket in the title?
  • Have you checked whether your jira ticket required DOCSP changes?
  • Have you checked for release_note changes?

Reminder (Please remove this when merging)

  • Please try to Approve or Reject Changes the PR, keep PRs in review as short as possible
  • Our Short Guide for PRs: Link
  • Remember the following Communication Standards - use comment prefixes for clarity:
    • blocking: Must be addressed before approval.
    • follow-up: Can be addressed in a later PR or ticket.
    • q: Clarifying question.
    • nit: Non-blocking suggestions.
    • note: Side-note, non-actionable. Example: Praise
    • --> no prefix is considered a question

@nammn nammn requested review from m1kola and Julien-Ben April 22, 2025 12:08
Co-Authored-By: Yavor Georgiev <[email protected]>
Co-Authored-By: Nam Nguyen <[email protected]>
Co-Authored-By: Mikalai Radchuk <[email protected]>
Copy link
Collaborator

@Julien-Ben Julien-Ben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and take a look a the failing tests as a follow up

@nammn nammn merged commit 26f0c1c into master Apr 22, 2025
1 check was pending
@m1kola m1kola mentioned this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants