Remove duplicated e2e_*_smoke_release variants.
#110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaciejKaras
force-pushed
the
fix/mk-smoke-tests
branch
from
bfe0c8c to
6d474e2
Compare
3 tasks
SimonBaeumer
approved these changes
May 13, 2025
| @@ -230,8 +230,8 @@ github_checks_aliases: | |||
| # Triggered on git tag | |||
| git_tag_aliases: | |||
| - git_tag: "^(\\d+\\.)?(\\d+\\.)?(\\d+)$" | |||
| variant_tags: [ "release" ] | |||
| task_tags: [ "image_release", "image_preflight", "openshift_bundles", "code_snippets" ] | |||
| variant_tags: [ "release", "e2e_smoke_release_test_suite" ] | |||
There was a problem hiding this comment.
Is my understanding correct that the release can be started without depending on successful e2e tests?
There was a problem hiding this comment.
yes, e2e_smoke_release_test_suite variant is only depending on init_test_run and nothing will block other release tasks to run
| variant_tags: [ "release" ] | ||
| task_tags: [ "image_release", "image_preflight", "openshift_bundles", "code_snippets" ] | ||
| variant_tags: [ "release", "e2e_smoke_release_test_suite" ] | ||
| task_tags: [ "image_release", "image_preflight", "openshift_bundles", "code_snippets", "patch-run" ] |
There was a problem hiding this comment.
Why does this now include patch-run task tags?
There was a problem hiding this comment.
patch-run is required because e2e_smoke_release_test_suite variant has tasks with that tag. It will only add tasks matching variant e2e_smoke_release_test_suite and not all e2e tests
|
@MaciejKaras Please ask @nammn or @mircea-cosbuc for a peer review too. I don't feel very confident reviewing this change. |
anandsyncs
approved these changes
May 13, 2025
Added `e2e_*_smoke_release` to `git_tag_aliases`
MaciejKaras
force-pushed
the
fix/mk-smoke-tests
branch
from
92605b1 to
3a6b3c2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added
e2e_*_smoke_releasetogit_tag_aliasesProof of Work
e2e_*_smoketasks are part of https://spruce.mongodb.com/version/682321bcc5dd2f0007539fd0/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESCChecklist
Reminder (Please remove this when merging)