Skip to content

Remove hard coded name #103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Jul 14, 2020
Merged

Remove hard coded name #103

merged 8 commits into from
Jul 14, 2020

Conversation

chatton
Copy link
Contributor

@chatton chatton commented Jul 14, 2020

All Submissions:

  • Have you signed our CLA?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

This PR fetches the MongoDB resources and dumps the config for each one. This should work for tests that deal with multiple MongoDB resources.

@chatton chatton requested a review from bznein July 14, 2020 14:14
bznein
bznein approved these changes Jul 14, 2020
View reviewed changes
Copy link
Contributor

@bznein bznein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great improvement! LGTM once we see on the tests that the dump works fine!

@chatton chatton merged commit 963f2d1 into master Jul 14, 2020
@chatton chatton deleted the remove_hard_coded_name branch July 14, 2020 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bznein bznein bznein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chatton @bznein