RUBY-2971 Add createCollection and collMod spec tests for changeStreamPreAndPostImages option #2487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-mongo
reviewed
May 11, 2022
p-mongo
approved these changes
May 11, 2022
Contributor
p-mongo
left a comment
p-mongo
left a comment
There was a problem hiding this comment.
Approved with the constant made api private + changes in the other PR for skipping.
neilshweky
force-pushed
the
RUBY-2971
branch
2 times, most recently
from
d9a1119 to
8942e25
Compare
comandeo
approved these changes
May 12, 2022
p-mongo
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RUBY-2971. Did not add the collMod spec tests since we don't have a modify collections helper function.
EDIT: Must review this PR first: #2488
I was able to add the modifyCollections test back after skipping unsupported operations.