Skip to content

PYTHON-3686 Consolidate CodecOptions Typings #1199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 28, 2023
Merged

PYTHON-3686 Consolidate CodecOptions Typings #1199

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee6b790
PYTHON-3686 Consolidate CodecOptions Typings
blink1073 Apr 28, 2023
4e9d9aa
use abc.abstractproperty
blink1073 Apr 28, 2023
598916f
cannot infer type abstract property type
blink1073 Apr 28, 2023
83add4b
formatting
blink1073 Apr 28, 2023
be47c26
revert
blink1073 Apr 28, 2023
2ef192a
remove mypy strict
blink1073 Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions .github/workflows/test-python.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,6 @@ jobs:
mypy --install-types --non-interactive --disable-error-code var-annotated --disable-error-code attr-defined --disable-error-code union-attr --disable-error-code assignment --disable-error-code no-redef --disable-error-code index --allow-redefinition --allow-untyped-globals --exclude "test/mypy_fails/*.*" test
python -m pip install -U typing_extensions
mypy --install-types --non-interactive test/test_typing.py test/test_typing_strict.py
- name: Run mypy strict
run: |
mypy --strict test/test_typing_strict.py
- name: Run pyright
run: |
python -m pip install -U pip pyright==1.1.290
Expand Down
2 changes: 1 addition & 1 deletion bson/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1115,7 +1115,7 @@ def decode_all(
if not isinstance(opts, CodecOptions):
raise _CODEC_OPTIONS_TYPE_ERROR

return _decode_all(data, opts) # type: ignore[arg-type]
return _decode_all(data, opts) # type:ignore[arg-type]


def _decode_selective(rawdoc: Any, fields: Any, codec_options: Any) -> Mapping[Any, Any]:
Expand Down
Loading