PHPLIB-345: Fix PHP shutdown error with dangling writable streams #779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
reviewed
Aug 31, 2020
jmikola
approved these changes
Sep 1, 2020
alcaeus
added a commit
that referenced
this pull request
Sep 1, 2020
* v1.7: PHPLIB-345: Fix PHP shutdown error with dangling writable streams (#779)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-345
This applies a suggestion by @sgolemon to avoid PHP trying to use previously destroyed stream objects. The behaviour can be shown by leaving a dangling writable stream, which causes errors on shutdown. The workaround ensures that the stream wrapper instance "forgets" that it owned a stream wrapper, as
StreamWrapper::stream_closeis called afterStreamWrapper::__destruct.