PHPLIB-70: DatabaseInfo models and index management #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmikola
changed the title
jmikola
force-pushed
the
phplib-70
branch
2 times, most recently
from
496779f to
8d8176c
Compare
| */ | ||
| public function dropIndex($indexName) | ||
| { | ||
| // TODO | ||
| // TODO: Add support for dropping indexes by keys/options (e.g. IndexModel) | ||
| $indexName = (string) $indexName; |
There was a problem hiding this comment.
If this string is empty, we should raise an InvalidArgumentException.
This obviates the need to handle stdClass instances within the results.
jmikola
force-pushed
the
phplib-70
branch
2 times, most recently
from
10207cb to
66048a4
Compare
Also change "read-only" language to "immutable".
This removes some copypasta from existing Database and Collection code.
This can be removed for PHPLIB-87 once PHPC-274 is resolved.
jmikola
added a commit
to jmikola/mongo-php-library
that referenced
this pull request
Apr 26, 2015
GromNaN
added a commit
to GromNaN/mongo-php-library
that referenced
this pull request
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-70