Skip to content

Fix readPreference option in benchmark #1664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 10, 2025
Merged

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Apr 10, 2025

Passing a ReadPreference to executeCommand is deprecated. The driver version 2 requires an array of options.

@GromNaN GromNaN requested a review from a team as a code owner April 10, 2025 11:03
@GromNaN GromNaN requested a review from jmikola April 10, 2025 11:03
@GromNaN GromNaN changed the base branch from v2.x to v1.21 April 10, 2025 11:03
@alcaeus
Copy link
Member

alcaeus commented Apr 10, 2025

evergreen keep-definitions

Copy link
Member

@alcaeus alcaeus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GromNaN GromNaN merged commit 4c88f33 into mongodb:v1.21 Apr 10, 2025
31 checks passed
@GromNaN GromNaN deleted the bench-readpref branch April 10, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants