Skip to content

PHPLIB-1531: Retry once when disabling fail points #1445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024
Merged

PHPLIB-1531: Retry once when disabling fail points #1445

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions tests/UnifiedSpecTests/ManagesFailPointsTrait.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

namespace MongoDB\Tests\UnifiedSpecTests;

use MongoDB\Driver\Exception\ConnectionException;
use MongoDB\Driver\Server;
use MongoDB\Operation\DatabaseCommand;
use stdClass;
Expand Down Expand Up @@ -31,8 +32,14 @@ public function configureFailPoint(stdClass $failPoint, Server $server): void
public function disableFailPoints(): void
{
foreach ($this->failPointsAndServers as [$failPoint, $server]) {
$operation = new DatabaseCommand('admin', ['configureFailPoint' => $failPoint, 'mode' => 'off']);
$operation->execute($server);
try {
$operation = new DatabaseCommand('admin', ['configureFailPoint' => $failPoint, 'mode' => 'off']);
$operation->execute($server);
} catch (ConnectionException $e) {
// Retry once in case the connection was dropped by the last operation
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still at a loss for why this wasn't an issue with the original FailPointObserver. There, the Server object was instantiated from the CommandStartedEvent; however, it's just an integer server_id and Manager reference. That's not much different from the object we're capturing here from configureFailPoint(). In both cases, the command to disable a fail point is still being executed via phongo_execute_command() with the same underlying mongoc_client_t and server_id.

The only difference I can identify is when we're disabling fail points. Previously, FailPointObserver disabled fail points during our equivalent of a tearDown() method. Now, we're doing so immediately after executing operations and before evaluating expectEvents (note: this is what the spec itself suggests). It's possible the previous deferral allowed some opportunity to reestablish a dropped connection.

This may be related to CDRIVER-4532, which highlights an outstanding libmongoc deficiency in the code paths utilized by PHPC.

$operation = new DatabaseCommand('admin', ['configureFailPoint' => $failPoint, 'mode' => 'off']);
$operation->execute($server);
}
}

$this->failPointsAndServers = [];
Expand Down