PHPLIB-1522: Deprecate info iterators #1438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GromNaN
reviewed
Sep 23, 2024
For now I'd leave in the assertion as a safe guard. We can update this in 2.x. I have added the templated return types for Psalm's benefit and updated the baseline. |
This was referenced Sep 23, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1522
This PR deprecates the
CollectionInfoIterator,DatabaseInfoIterator, andIndexInfoIteratorinterfaces and implementing classes. These will be replaced with generic iterators in 2.0.In addition to this change, this PR also deprecates
IndexInfo::getNamespace. Thensfield that feeds this method has been removed from output in MongoDB 4.4, and keeping the necessary code added in PHPLIB-499 around makes no sense going forward.