PHPLIB-1330: Sync tests for failCommand errorLabels reqs #1214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Jan 11, 2024
GromNaN
approved these changes
Jan 11, 2024
Synced with mongodb/specifications@5fc23f4 Updates retryable writes prose test 3 to relocate the errorLabels field when configuring a fail point. Fixes prose test numbering, which dates back to f236312. Updates the prose test requirement per mongodb/specifications@0d67e87, which was missed in the original PHPLIB commit. Some spec tests are dependent on outstanding issues: command-monitoring/find.json (PHPLIB-1080) and valid-pass/entity-commandCursor.json (PHPLIB-1077)
Merged
4 tasks
alcaeus
added a commit
to alcaeus/mongo-php-library
that referenced
this pull request
Jan 15, 2024
* master: PHPLIB-1323 Implement `unlink` for GridFS stream wrapper (mongodb#1206) PHPLIB-1330: Sync tests for failCommand errorLabels reqs (mongodb#1214) PHPLIB-1246: Test PHP 8.3 on Evergreen (mongodb#1213) PHPLIB-1324 Implement `rename` for GridFS stream wrapper (mongodb#1207) PHPLIB-1248 Add examples on GridFS (mongodb#1196) Deprecate setting GridFS disableMD5 to false explicitly (mongodb#1205) PHPLIB-1326: Use more permissive top-level runOnRequirements (mongodb#1210) PHPLIB-1206 Add bucket alises for context resolver using GridFS StreamWrapper (mongodb#1138) Bump actions/upload-artifact from 3 to 4 (mongodb#1208) PHPLIB-1275: Replace apiargs usage in docs with extracts (mongodb#1203) Fix title formatting in Client::removeSubscriber() docs (mongodb#1204) PHPLIB-1304: Pull mongohouse image from ECR repo (mongodb#1202) Fix evergreen failures (mongodb#1200) Enable workflows to run for GitHub Merge Queue (mongodb#1199) PHPLIB-1313 Ensure the GridFS stream is saved when the script ends (mongodb#1197) PHPLIB-1309 Add addSubscriber/removeSubscriber to Client class to ease configuration (mongodb#1195) Master is now 1.18-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPLIB-1330
Synced with mongodb/specifications@5fc23f4
Updates retryable writes prose test 3 to relocate the errorLabels field when configuring a fail point.
Fixes prose test numbering, which dates back to f236312.
Updates the prose test requirement per mongodb/specifications@0d67e87, which was missed in the original PHPLIB commit.
Some spec tests are dependent on outstanding issues: command-monitoring/find.json (PHPLIB-1080) and valid-pass/entity-commandCursor.json (PHPLIB-1077)