Skip to content

PHPLIB-1208: Split example namespaces #1139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2023
Merged

PHPLIB-1208: Split example namespaces #1139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/aggregate.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace MongoDB\Examples;
namespace MongoDB\Examples\Aggregate;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to have the same problem with the CSFLE examples? Or perhaps not because those don't define any functions?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Potentially, yes. In this particular case we won't, however I consider this an upstream issue, as blindly compiling every PHP file regardless of whether it's even available to be autoloader is an error. The PR @GromNaN created in the library excludes all files in examples folders from compilation, which fixes the issue for good. This is just a temporary workaround to resolve the immediate issue until it can be fixed upstream.


use MongoDB\Client;

Expand Down
2 changes: 1 addition & 1 deletion examples/bulk.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace MongoDB\Examples;
namespace MongoDB\Examples\Bulk;

use MongoDB\Client;
use MongoDB\Driver\WriteConcern;
Expand Down
2 changes: 1 addition & 1 deletion examples/changestream.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace MongoDB\Examples;
namespace MongoDB\Examples\ChangeStream;

use MongoDB\Client;

Expand Down
2 changes: 1 addition & 1 deletion examples/command_logger.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace MongoDB\Examples;
namespace MongoDB\Examples\CommandLogger;

use MongoDB\Client;
use MongoDB\Driver\Monitoring\CommandFailedEvent;
Expand Down
2 changes: 1 addition & 1 deletion examples/persistable.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace MongoDB\Examples;
namespace MongoDB\Examples\Persistable;

use MongoDB\BSON\ObjectId;
use MongoDB\BSON\Persistable;
Expand Down
2 changes: 1 addition & 1 deletion examples/typemap.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace MongoDB\Examples;
namespace MongoDB\Examples\Typemap;

use MongoDB\BSON\ObjectId;
use MongoDB\BSON\Unserializable;
Expand Down
2 changes: 1 addition & 1 deletion examples/with_transaction.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?php
declare(strict_types=1);

namespace MongoDB\Examples;
namespace MongoDB\Examples\WithTransaction;

use MongoDB\Client;
use MongoDB\Driver\Session;
Expand Down
28 changes: 14 additions & 14 deletions tests/ExamplesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,23 +90,23 @@ public function dataExamples(): Generator
];

$expectedOutput = <<<'OUTPUT'
MongoDB\Examples\PersistableEntry Object
MongoDB\Examples\Persistable\PersistableEntry Object
(
[id:MongoDB\Examples\PersistableEntry:private] => MongoDB\BSON\ObjectId Object
[id:MongoDB\Examples\Persistable\PersistableEntry:private] => MongoDB\BSON\ObjectId Object
(
[oid] => %s
)

[name] => alcaeus
[emails] => Array
(
[0] => MongoDB\Examples\PersistableEmail Object
[0] => MongoDB\Examples\Persistable\PersistableEmail Object
(
[type] => work
[address] => [email protected]
)

[1] => MongoDB\Examples\PersistableEmail Object
[1] => MongoDB\Examples\Persistable\PersistableEmail Object
(
[type] => private
[address] => [email protected]
Expand All @@ -123,26 +123,26 @@ public function dataExamples(): Generator
];

$expectedOutput = <<<'OUTPUT'
MongoDB\Examples\TypeMapEntry Object
MongoDB\Examples\Typemap\TypeMapEntry Object
(
[id:MongoDB\Examples\TypeMapEntry:private] => MongoDB\BSON\ObjectId Object
[id:MongoDB\Examples\Typemap\TypeMapEntry:private] => MongoDB\BSON\ObjectId Object
(
[oid] => %s
)

[name:MongoDB\Examples\TypeMapEntry:private] => alcaeus
[emails:MongoDB\Examples\TypeMapEntry:private] => Array
[name:MongoDB\Examples\Typemap\TypeMapEntry:private] => alcaeus
[emails:MongoDB\Examples\Typemap\TypeMapEntry:private] => Array
(
[0] => MongoDB\Examples\TypeMapEmail Object
[0] => MongoDB\Examples\Typemap\TypeMapEmail Object
(
[type:MongoDB\Examples\TypeMapEmail:private] => work
[address:MongoDB\Examples\TypeMapEmail:private] => [email protected]
[type:MongoDB\Examples\Typemap\TypeMapEmail:private] => work
[address:MongoDB\Examples\Typemap\TypeMapEmail:private] => [email protected]
)

[1] => MongoDB\Examples\TypeMapEmail Object
[1] => MongoDB\Examples\Typemap\TypeMapEmail Object
(
[type:MongoDB\Examples\TypeMapEmail:private] => private
[address:MongoDB\Examples\TypeMapEmail:private] => [email protected]
[type:MongoDB\Examples\Typemap\TypeMapEmail:private] => private
[address:MongoDB\Examples\Typemap\TypeMapEmail:private] => [email protected]
)

)
Expand Down