PHPLIB-1208: Split example namespaces #1139
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPLIB-1208
The appstract/laravel-opcache package looks compiles all php files using
opcache_compile_file
. This creates some duplicate function declarations in our example files. Since we want to ship the examples for users' benefit, these files need to be excluded by another measure.Luckily, the package excludes files containing a shebang, so adding that and making the examples executable not only fixes the opcache issues, but also makes them a little easier to run.The above solution does not work on all PHP versions, as our tests require the files and the addition of the shebang makes the
declare
andnamespace
declarations no longer the first statements in the file. To work around the conflicts observed when compiling for opcache, the examples now use separate namespaces.