PHPC-2350: Test that PackedArray::fromJSON() accepts objects with valid keys #1703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alcaeus
approved these changes
Sep 30, 2024
| @@ -10,6 +10,8 @@ $tests = [ | |||
| '[ 1, 2, 3 ]', | |||
| '[[ 1, 2, 3 ]]', | |||
| '[{ "bar": 1 }]', | |||
| // JSON objects are accepted iff the keys are valid | |||
There was a problem hiding this comment.
I was gonna nitpick the typo, but TIL that iff is an actual word.
There was a problem hiding this comment.
Yes, I don't like how easily this can be mixed up for a typo but it'd be a complete waste of space to write "if and only if"
This was referenced Sep 30, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2350
This came to me while writing PHP docs and I realized it was never tested in the original PR (#1645). I don't think this warrants a separate ticket.