CSHARP-3985: Support multiple SerializerRegistries #1592
+4,901
−1,782
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using System.Collections.Generic; | ||
| using System.Dynamic; | ||
| using MongoDB.Bson.Serialization; | ||
|
|
||
| namespace MongoDB.Bson | ||
| { | ||
| internal class BsonDefaultsDomain : IBsonDefaults | ||
|
There was a problem hiding this comment. Is it possible for this class to be immutable? There was a problem hiding this comment. Same as before, we can decide to make this immutable when this is created with builders. |
||
| { | ||
| private IBsonSerializationDomain _serializationDomain; | ||
| private bool _dynamicArraySerializerWasSet; | ||
| private IBsonSerializer _dynamicArraySerializer; | ||
| private bool _dynamicDocumentSerializerWasSet; | ||
| private IBsonSerializer _dynamicDocumentSerializer; | ||
|
|
||
| public BsonDefaultsDomain(IBsonSerializationDomain serializationDomain) | ||
| { | ||
| _serializationDomain = serializationDomain; | ||
| } | ||
|
|
||
| public IBsonSerializer DynamicArraySerializer | ||
| { | ||
| get | ||
| { | ||
| if (!_dynamicArraySerializerWasSet) | ||
| { | ||
| _dynamicArraySerializer = _serializationDomain.LookupSerializer<List<object>>(); | ||
| } | ||
| return _dynamicArraySerializer; | ||
| } | ||
| set | ||
| { | ||
| _dynamicArraySerializerWasSet = true; | ||
| _dynamicArraySerializer = value; | ||
| } | ||
| } | ||
|
|
||
| public IBsonSerializer DynamicDocumentSerializer | ||
| { | ||
| get | ||
| { | ||
| if (!_dynamicDocumentSerializerWasSet) | ||
| { | ||
| _dynamicDocumentSerializer = _serializationDomain.LookupSerializer<ExpandoObject>(); | ||
| } | ||
| return _dynamicDocumentSerializer; | ||
| } | ||
| set | ||
| { | ||
| _dynamicDocumentSerializerWasSet = true; | ||
| _dynamicDocumentSerializer = value; | ||
| } | ||
| } | ||
|
|
||
| public int MaxDocumentSize { get; set; } = int.MaxValue; | ||
|
|
||
| public int MaxSerializationDepth { get; set; } = 100; | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| /* Copyright 2010-present MongoDB Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| using MongoDB.Bson.Serialization; | ||
|
|
||
| namespace MongoDB.Bson | ||
| { | ||
| internal interface IBsonDefaults | ||
| { | ||
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| IBsonSerializer DynamicArraySerializer { get; set; } | ||
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| IBsonSerializer DynamicDocumentSerializer { get; set; } | ||
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| int MaxDocumentSize { get; set; } | ||
| /// <summary> | ||
| /// | ||
| /// </summary> | ||
| int MaxSerializationDepth { get; set; } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -321,13 +321,13 @@ public virtual IByteBuffer ReadRawBsonArray() | |
| // overridden in BsonBinaryReader to read the raw bytes from the stream | ||
| // for all other streams, deserialize the array and reserialize it using a BsonBinaryWriter to get the raw bytes | ||
|
|
||
| var deserializationContext = BsonDeserializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain); | ||
|
There was a problem hiding this comment. Do we really need a domain for RawBsonArray/RawBsonDocument? Another idea to address all "default domain" questions: We can consider having some simplified version of There was a problem hiding this comment. Here I was not sure if we're dealing only with If so this is the perfect place to address the fact that in my opinion we need to have another kind of domain around. |
||
| var array = BsonArraySerializer.Instance.Deserialize(deserializationContext); | ||
|
|
||
| using (var memoryStream = new MemoryStream()) | ||
| using (var bsonWriter = new BsonBinaryWriter(memoryStream, BsonBinaryWriterSettings.Defaults)) | ||
| { | ||
| var serializationContext = BsonSerializationContext.CreateRoot(bsonWriter, BsonSerializer.DefaultSerializationDomain); | ||
| bsonWriter.WriteStartDocument(); | ||
| var startPosition = memoryStream.Position + 3; // just past BsonType, "x" and null byte | ||
| bsonWriter.WriteName("x"); | ||
|
|
@@ -351,7 +351,7 @@ public virtual IByteBuffer ReadRawBsonDocument() | |
| // overridden in BsonBinaryReader to read the raw bytes from the stream | ||
| // for all other streams, deserialize the document and use ToBson to get the raw bytes | ||
|
|
||
| var deserializationContext = BsonDeserializationContext.CreateRoot(this, BsonSerializer.DefaultSerializationDomain); | ||
| var document = BsonDocumentSerializer.Instance.Deserialize(deserializationContext); | ||
| var bytes = document.ToBson(); | ||
| return new ByteArrayBuffer(bytes, isReadOnly: true); | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it possible for this class to be immutable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could when we have builders and we'll have only setters.