Updates Code example [LG-2954, LG-2950, LG-2951] #1700
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheSonOfThomp
changed the title
|
Size Change: -220 B (0%) Total Size: 917 kB
ℹ️ View Unchanged
|
bruugey
reviewed
Apr 24, 2023
spark33
reviewed
Apr 25, 2023
| argTypes: { | ||
| ...storybookArgTypes, | ||
| darkMode: storybookArgTypes.darkMode, | ||
| baseFontSize: storybookArgTypes.updatedBaseFontSize, |
There was a problem hiding this comment.
Doesn't this mean we have to explicitly exclude baseFontSize in every component even if they don't support the prop? I'm assuming that we envision every component's story meta extending this object in the future
There was a problem hiding this comment.
This will be passed into the LeafyGreenProvider if the component doesn't support the prop. (this is also how it worked before with the spread)
Convert to using StoryMeta
bruugey
approved these changes
Apr 25, 2023
bruugey
pushed a commit
that referenced
this pull request
Aug 9, 2023
* Update Portal.story.tsx * moves menu item children in story * ignore stories.js* * Update StoryMeta.ts * moves menu children back * import StoryMeta in typography story * Update Toast.story.tsx * Updates default `as` prop in SB * updates Button tsdoc * add comments * Update Toast.story.tsx * rm children, as from default StoryMeta * fix story meta tests * Create lovely-drinks-fix.md * use correct constant in seg-ctrl story * matk storybookArgTypes as const * changesets * Rename type to StoryMetaType * Update small-baboons-smile.md * fixes prop types in banner & box * rm children from excluded params * explicitly exclude children from args. Convert to using StoryMeta * Create lovely-zebras-shout.md * ts fix * exclude props from table story * adds display name to Stepper * Create early-suns-protect.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Proposed changes
🎟 Jira ticket: Name of ticket
✅ Checklist
For bug fixes, new features & breaking changes
yarn changesetand documented my changesFor new components
🧪 How to test changes