PHPORM-369: Fix ID handling when using insert method instead of save #3429
+68
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHPORM-369
Checklist
This addresses an issue highlighted in a discussion about
rename_embedded_id_field
: when usingDB::table()->insert
, we pass$values
directly toaliasIdForQuery
. Since$values
contains a list of documents at this point, every document is treated as an embedded document and misses out on the ID handling for root documents. To work around this, we callaliasIdForQuery
on each document througharray_map
.I also added a test with a model that has
$incrementing
set tofalse
, as the wrong behaviour is bypassed when$incrementing
is its defaulttrue
value.