Skip to content

fix(NODE-6552): remove cache and use toStringTag in type helpers #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
W-A-James merged 7 commits into from
Nov 27, 2024
Merged

fix(NODE-6552): remove cache and use toStringTag in type helpers #740

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
43f6403
Revert "perf(NODE-6356): Improve serialization performance (#709)"
nbbeeken Nov 21, 2024
e251a8a
chore: keep condition improvement
nbbeeken Nov 22, 2024
ced10d7
chore: remove WeakMap cache of types and use toStringTag getter
nbbeeken Nov 22, 2024
8d2c0f3
fix: param name
nbbeeken Nov 22, 2024
dd11dcb
perf: add instanceof checks
nbbeeken Nov 26, 2024
fd2e7dd
chore: use toStringTag getter
nbbeeken Nov 26, 2024
fac472e
chore: comment for reference
nbbeeken Nov 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 13 additions & 26 deletions src/parser/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,37 +1,24 @@
export function isAnyArrayBuffer(value: unknown): value is ArrayBuffer {
return (
typeof value === 'object' &&
value != null &&
Symbol.toStringTag in value &&
(value[Symbol.toStringTag] === 'ArrayBuffer' ||
value[Symbol.toStringTag] === 'SharedArrayBuffer')
);
}
const TypedArrayPrototypeGetSymbolToStringTag = (() => {
// eslint-disable-next-line @typescript-eslint/unbound-method -- the intention is to call this method with a bound value
const g = Object.getOwnPropertyDescriptor(
Object.getPrototypeOf(Uint8Array.prototype),
Symbol.toStringTag
)!.get!;

export function isUint8Array(value: unknown): value is Uint8Array {
return (
typeof value === 'object' &&
value != null &&
Symbol.toStringTag in value &&
value[Symbol.toStringTag] === 'Uint8Array'
);
}
return (value: unknown) => g.call(value);
})();

export function isBigInt64Array(value: unknown): value is BigInt64Array {
return (
typeof value === 'object' &&
value != null &&
Symbol.toStringTag in value &&
value[Symbol.toStringTag] === 'BigInt64Array'
);
export function isUint8Array(value: unknown): value is Uint8Array {
return TypedArrayPrototypeGetSymbolToStringTag(value) === 'Uint8Array';
}

export function isBigUInt64Array(value: unknown): value is BigUint64Array {
export function isAnyArrayBuffer(value: unknown): value is ArrayBuffer {
return (
typeof value === 'object' &&
value != null &&
Symbol.toStringTag in value &&
value[Symbol.toStringTag] === 'BigUint64Array'
(value[Symbol.toStringTag] === 'ArrayBuffer' ||
value[Symbol.toStringTag] === 'SharedArrayBuffer')
);
}

Expand Down