feat(NODE-4873): support EJSON stringify from BigInt to $numberLong #547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
W-A-James
commented
Jan 3, 2023
nbbeeken
suggested changes
Jan 3, 2023
W-A-James
force-pushed
the
NODE-4873/support_ejson_fromBigInt_to_numberLong
branch
from
77af61e to
3526efd
Compare
nbbeeken
approved these changes
Jan 4, 2023
nbbeeken
suggested changes
Jan 4, 2023
Contributor
nbbeeken
left a comment
nbbeeken
left a comment
There was a problem hiding this comment.
We discussed on slack one more test about loose equality working, and js string == EJSON string
nbbeeken
suggested changes
Jan 4, 2023
W-A-James
commented
Jan 6, 2023
nbbeeken
previously approved these changes
Jan 6, 2023
baileympearson
requested changes
Jan 12, 2023
nbbeeken
approved these changes
Jan 18, 2023
baileympearson
approved these changes
Jan 18, 2023
nbbeeken
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
Adding capability to stringify BigInt
Is there new documentation needed for these changes?
No
What is the motivation for this change?
Allow users to make use of native Javascript
BigInts instead ofBSON.LongDouble check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript