fix: accept Uint8Array where Buffer is accepted #432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
commented
Apr 22, 2021
| potentialBuffer.buffer, | ||
| potentialBuffer.byteOffset, | ||
| potentialBuffer.byteLength | ||
| ); |
Contributor
Author
There was a problem hiding this comment.
I know the bug was here before anyway, but I should absolutely have caught this during #429, sorry.
nbbeeken
requested review from
a team,
dariakp and
nbbeeken
and removed request for
a team
Also fixes NODE-3223 (ensureBuffer ignores byteLength/byteOffset). This is the "proper" alternative to mongodb#418 and matches what e.g. Node.js APIs do.
Contributor
Author
|
Rebased to resolve the merge conflict ( |
Contributor
Author
If you merge this, yes. :) |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also fixes NODE-3223 (ensureBuffer ignores byteLength/byteOffset).
This is the "proper" alternative to #418 and matches what e.g. Node.js APIs do.
Description
What changed?