Skip to content

DOCSP-18495 link to sharding in agg ebook #5964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2021
Merged

DOCSP-18495 link to sharding in agg ebook #5964

merged 1 commit into from
Oct 12, 2021

Conversation

ghost
Copy link

@ghost ghost commented Oct 8, 2021

No description provided.

<https://www.practical-mongodb-aggregations.com/guides/sharding.html>`__
e-book.


For details, see:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way this is staged, we have the "For details, see: " as part of the new "E-book" section. As a reader, since these are part of the E-book section, i now expect these to be links within the e-book.

We should consider adding a sub-heading for these docs links like "Additional Information" or similar for these links.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a new section heading.

Would you have a look?

Copy link
Collaborator

@jeff-allen-mongo jeff-allen-mongo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adjusting

@jeff-allen-mongo jeff-allen-mongo merged commit b39eb98 into mongodb:master Oct 12, 2021
mongo-cr-bot pushed a commit that referenced this pull request Jan 24, 2024
* DOCSP-35091-majority-write-concern-updates

* DOCSP-35091-majority-write-concern-updates

* DOCSP-35091-majority-write-concern-updates

* DOCSP-35091-majority-write-concern-updates

---------

Co-authored-by: jason-price-mongodb <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants