-
Notifications
You must be signed in to change notification settings - Fork 1.7k
made edits, but left some TODOs for you #52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'll merge in tomorrow. Eliot's proof'd http://docs.mongodb.org/manual/tutorial/expire-data/ and the new section is consistent with that. |
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
May 22, 2025
* DOCSP-23350 write-blokcing note * staging updates * Review feedback * Review feedback * Review feedback * Review feedback * Review feedback
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
May 22, 2025
* DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration page * DOCSP-22863 Configuration Setting/Option Map * DOCSP-22863 Configuration Setting/Option Map * DOCSP-22863 Configuration introduction * DOCSP-22863 Test cluster0 include * DOCSP-22863 Include updates * DOCSP-22863 Spelling * DOCSP-22863 Typo * DOCSP-22863 header content * DOCSP-22863 Alphabetizes CLI options * DOCSP-22863 Reorders TOC * DOCSP-22863 Fixes per Alan Zheng * DOCSP-22863 Fixes per Ian Fogelman * DOCSP-22863 Fixes per Ian Fogelman * DOCSP-22863 Fixes per Alan Zheng * DOCSP-22863 Fixes build error * DOCSP-22863 Fixes build error * DOCSP-22863 Fixes build error * DOCSP-22863 Fixes build error * DOCSP-23350 write-blocking note (#52) * DOCSP-23350 write-blokcing note * staging updates * Review feedback * Review feedback * Review feedback * Review feedback * Review feedback * DOCSP-23337 users and roles not synched (#55) * DOCSP-23337 users and roles not synched * Review feedback * Review feedback * DOCS-15427 System Collection Limitations (#59) * DOCS-15427 Adds System Collection limitation * DOCS-15427 Adds System Collection limitation * DOCS-15427 Fixes per Joe * DOCS-15427 Fixes per Joe * Merge with upstream master * Merge with upstream master * Merge with upstream master * Merge with upstream master * DOCSP-22863 Alphabetizes CLI options * DOCSP-22863 Build errors * DOCSP-22863 Build errors * DOCSP-22863 Build errors * DOCSP-22863 Fixes per Tim Fogarty * DOCSP-22863 Increases depth on mongosync * DOCSP-22863 Fixes per Tim Fogarty * DOCSP-22863 Fixes build error Co-authored-by: Dave Cuthbert <[email protected]>
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 2, 2025
DOCSP-20368: Removing obsolete file from repo
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 6, 2025
DOCSP-33185 Stop / Resume Sync Job Considerations
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jun 24, 2025
* DOCSP-10925: document uuid format strategy
mongodb-server-docs-sync-bot bot
pushed a commit
that referenced
this pull request
Jul 11, 2025
* DOCSP-11107 describe how to retrieve iamAssumedRoleArn (#54) * DOCSP-11107 describe how to retrieve iamAssumedRoleArn * DOCSP-11107 updates for tech review feedback * DOCSP-11233 creation API returns user ARN and External ID (#52) * DOCSP-11233 creation API returns user ARN and External ID DOCSP-11233 self-review DOCSP-11233 typo fix * DOCSP-11233 updates for tech review feedback DOCSP-11233 minor fix * DOCSP-11908 api doc for updating adl (#63) * DOCSP-11908 api doc for updating adl * DOCSP-11908 self-review DOCSP-11908 fixing broken includes * DOCSP-11908 updates for external review feedback DOCSP-11908 minor tweak * Apply suggestions from code review accepting copy review changes Co-authored-by: Chris Bush <[email protected]> Co-authored-by: Chris Bush <[email protected]> * DOCSP-11810 api doc for creating adl (#62) * DOCSP-11810 api doc for creating adl DOCSP-11810 self-review DOCSP-11810 self-review DOCSP-11810 self-review DOCSP-11810 self-review DOCSP-11810 response updates DOCSP-11810 self-review DOCSP-11810 fixing includes * DOCSP-11810 update for tech review * Apply suggestions from code review accepting proposed copy review feedback Co-authored-by: Chris Bush <[email protected]> Co-authored-by: Chris Bush <[email protected]> * DOCSP-11588 doc for unified AWS access (#53) * DOCSP-11588 doc for unified Atlas access DOCSP-11588 minor corrections DOCSP-11588 doc fix DOCSP-11588 fixes DOCSP-11588 doc updates * DOCSP-11588 updates for tech review feedback DOCSP-11588 minor fix DOCSP-11588 fixing links DOCSP-11588 minor typo fix * DOCSP-11588 updates for external review feedback DOCSP-11588 minor tweak * DOCSP-11588 updates for review feedback DOCSP-11588 minor typo Co-authored-by: Chris Bush <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a variety of edits, but left some TODO's for you to fill in. Also, I didn't really check the TTL part, since it's new and I'm not familiar with it. You should have Eliot proof that.
I'm happy to do another pass if needed later. Let me know if you have any questions.