Skip to content

DOCS-10958 networkMessageCompressors disabled by default in shell. #3083

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jdestefano-mongo
Copy link
Collaborator

@jdestefano-mongo jdestefano-mongo commented Nov 6, 2017

This change is Reviewable


- Enabled by default. To disable, set to ``disabled``.
- Enabled by default using the :term:`snappy` compressor. To
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like we use the snappy compressor to enable this feature.

maybe:
MongoDB enables snappy network compression for communication, by default. To disable compression ...

- a :program:`mongo` shell

- a :program:`mongo` shell when network compression is enabled
(disabled by default)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the phrase "when network compression is enabled (disabled by default)":

-- unclear that you are referring to mongo shell's compression enablement
-- given that this is followed by a blurb that states that both sides must have this feature enabled (whether other members of sharded cluster, etc), it's unnecessary as stated. We can either just state that mongo shell disables this feature by default. or just remove it all together.


- Add support for :term:`zlib` compressor.
- Enabled by default. To disable, set to ``disabled``.

- Disabled by default in the :program:`mongo` shell.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, it was disabled in the mongo shell in 3.4. So, this probably doesn't need to be in part of the 3.6 changes

- Enabled by default. To disable, set to ``disabled``.
- Add support for :term:`zlib` compressor.

- Enabled by default using the :term:`snappy` compressor. To
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds like we use the snappy compressor to enable this feature.

@@ -2637,7 +2640,8 @@ description: |
- other members of the sharded cluster, if the instance is part of a
sharded cluster

- a :program:`mongo` shell,
- a :program:`mongo` shell when network compression is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before.

Add support for :term:`zlib` compressor.
- Add support for :term:`zlib` compressor.

- Enabled by default using the :term:`snappy` compressor. To
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same as before.


Enables network compression for communication between this
{{program}} instance and:

- other members of the sharded cluster

- a :program:`mongo` shell.
- a :program:`mongo` shell when network compression is enabled
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@kay-kim
Copy link
Contributor

kay-kim commented Dec 13, 2018

Closing as done through another ticket.

@kay-kim kay-kim closed this Dec 13, 2018
mongo-cr-bot pushed a commit that referenced this pull request May 31, 2023
* (DOCSP-29528): Improve SBE release notes (#3068) (#3083)

* (DOCSP-29528): Improve SBE release notes

* wording tweak

* wording

* change section title

* (DOCSP-29529): Update log messages for SBE 7.0 changes (#3224)

* (DOCSP-29529): Update log messages for SBE 7.0 changes

* line spacing

* copy review edits

* wording

* update release version

* DOCSP-29530 Adjust $planCacheStats output for SBE (#3201)

* formatting tabs

* fix build error

* formatting tab title

* add more sbe content

* fill out SBE table

* try to fix linting

* edit examples

* remove version added for SBE

* add version changed

* fix formatting for code block

* single sourcing

* fix ref errors

* wording

* remove 'i.e.'

* format field names in table

* fix spacing for example comments

* address review comments

* Update source/includes/planCacheStats/indexFilterSet.rst

Co-authored-by: Ruoxin Xu <[email protected]>

* fix cachedPlan link

* wording

---------

Co-authored-by: Ruoxin Xu <[email protected]>

---------

Co-authored-by: Ruoxin Xu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants