improvements to findAndModify/db.collection.findAndModify ref #2078
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -117,19 +116,22 @@ multiple clients issue the following command: | |||
|
|
|||
| If all the commands finish the ``query`` phase before any command | |||
| starts the ``modify`` phase, **and** there is no unique index on the | |||
| ``name`` field, the commands may all result in an insert. To prevent | |||
| ``name`` field, the commands may all perform an upsert, creating | |||
|
My notes in, otherwise LGTM. |
| field, the commands may all perform an upsert, creating | ||
| multiple duplicate documents. | ||
|
|
||
| To prevent this |
There was a problem hiding this comment.
replace "this condition" with the condition, given that its in its own paragraph now
|
lgtm modulo comments |
|
Merged, with Sam & Michael's feedback. |
mongo-cr-bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
…ial in v6.0 (#2069) (#2078) * DOCSP-25533 removes incorrect statement from "Clear Jumbo Flag" tutorial * internal review feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.