Skip to content

DOCSP-30132 bug reported on key converter #117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2023

Conversation

caitlindavey
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-30132?filter=-2
Staging - https://docs-mongodbcom-staging.corp.mongodb.com/kafka-connector/docsworker-xlarge/DOCSP-30132-key-converter/introduction/converters/

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?

@caitlindavey caitlindavey requested a review from rustagir May 31, 2023 19:38
Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the staging, it looks like there are still places on this page where the property name needs to be corrected.

  • avro converter - source tab
  • json schema converter - source tab

.gitignore Outdated
@@ -8,3 +8,4 @@ fabfile
giza.log
backups
*.swp
.vscode/
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: why was this changed in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added it in to my file and hoped it would not be in future. It can be removed

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Contributor

@rustagir rustagir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@caitlindavey caitlindavey merged commit 5f745c8 into mongodb:master May 31, 2023
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request May 31, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request Jun 1, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request Jun 1, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request Jun 1, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request Jun 1, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request Jun 1, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request Jun 1, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit to caitlindavey/docs-kafka-connector that referenced this pull request Jun 1, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
caitlindavey added a commit that referenced this pull request Jun 2, 2023
* DOCSP-30132 bug reported on key converter

* DOCSP-30132 bug reported on key converter source

* Update .gitignore

---------

Co-authored-by: Caitlin Davey <[email protected]>
(cherry picked from commit 5f745c8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants