Skip to content

DOCSP-51244: Fix short page: previous versions #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 23, 2025

Conversation

norareidy
Copy link
Collaborator

@norareidy norareidy commented Jul 22, 2025

Pull Request Info

PR Reviewing Guidelines

JIRA - DOCSP-51244

Staging Links

  • index
  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?
    • Are the page titles greater than 20 characters long and SEO relevant?

    Copy link

    netlify bot commented Jul 22, 2025

    Deploy Preview for docs-csharp ready!

    Name Link
    🔨 Latest commit 8ce714c
    🔍 Latest deploy log https://app.netlify.com/projects/docs-csharp/deploys/687fd04b06574d00087c5b5b
    😎 Deploy Preview https://deploy-preview-673--docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify project configuration.

    @docs-builder-bot
    Copy link

    docs-builder-bot commented Jul 22, 2025

    🔄 Deploy Preview for docs-csharp processing

    Item Details
    🔨 Latest Commit 96cb9fb2efe43856a2180c426953adac1a281e51
    😎 Deploy Preview https://deploy-preview-673--docs-csharp.netlify.app
    🔍 Build Logs View Logs

    Copy link
    Collaborator

    @mongoKart mongoKart left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM I think, though I still don't know the best way to handle previous versions. These docs are all EOL in October, so I think it's fine for now.

    To learn about the features of previous versions of the {+driver-short+}, visit the
    following links:

    - `Version 2.18 <https://mongodb.github.io/mongo-csharp-driver/2.18/>`__
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    S: Since this is the What's New page, does it make sense to add a single link for all previous versions, and have it point here?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Good idea! updated

    @norareidy norareidy requested review from a team and adelinowona and removed request for a team July 22, 2025 20:00

    .. _csharp-previous-versions:

    Previous Versions
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Note to tech reviewer: let me know if you think this is a good place for these links

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    yeah it's good

    Copy link

    @adelinowona adelinowona left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @norareidy norareidy merged commit deac37c into mongodb:v2.30 Jul 23, 2025
    5 of 6 checks passed
    @norareidy norareidy deleted the DOCSP-51244-move-prev-versions branch July 23, 2025 20:09
    norareidy added a commit that referenced this pull request Jul 23, 2025
    * DOCSP-51244: Fix short page: previous versions
    
    * edits
    
    * MW feedback
    
    (cherry picked from commit deac37c)
    norareidy added a commit that referenced this pull request Jul 23, 2025
    * DOCSP-51244: Fix short page: previous versions
    
    * edits
    
    * MW feedback
    
    (cherry picked from commit deac37c)
    (cherry picked from commit 998d118)
    norareidy added a commit that referenced this pull request Jul 23, 2025
    * DOCSP-51244: Fix short page: previous versions
    
    * edits
    
    * MW feedback
    
    (cherry picked from commit deac37c)
    (cherry picked from commit 998d118)
    norareidy added a commit that referenced this pull request Jul 23, 2025
    * DOCSP-51244: Fix short page: previous versions
    
    * edits
    
    * MW feedback
    
    (cherry picked from commit deac37c)
    (cherry picked from commit 998d118)
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    4 participants