-
Notifications
You must be signed in to change notification settings - Fork 25
DOCSP-51244: Fix short page: previous versions #673
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOCSP-51244: Fix short page: previous versions #673
Conversation
✅ Deploy Preview for docs-csharp ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🔄 Deploy Preview for docs-csharp processing
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM I think, though I still don't know the best way to handle previous versions. These docs are all EOL in October, so I think it's fine for now.
source/whats-new.txt
Outdated
To learn about the features of previous versions of the {+driver-short+}, visit the | ||
following links: | ||
|
||
- `Version 2.18 <https://mongodb.github.io/mongo-csharp-driver/2.18/>`__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Since this is the What's New page, does it make sense to add a single link for all previous versions, and have it point here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! updated
|
||
.. _csharp-previous-versions: | ||
|
||
Previous Versions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to tech reviewer: let me know if you think this is a good place for these links
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah it's good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* DOCSP-51244: Fix short page: previous versions * edits * MW feedback (cherry picked from commit deac37c)
Pull Request Info
PR Reviewing Guidelines
JIRA - DOCSP-51244
Staging Links
Self-Review Checklist