-
Notifications
You must be signed in to change notification settings - Fork 26
DOCSP-39359 - GCP OIDC #210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, a couple of small suggestions/comments.
:tabid: mongodb-gcp-imds-connection-string | ||
|
||
The following code example shows how to specify GCP IMDS OIDC authentication. | ||
Replace the ``<percent-encoded audience>`` placeholder with the percent-encoded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Question: Does the audience have to be percent-encoded? The PyMongo driver currently does not require percent-encoding for the audience value so it would be great to clarify whether this driver also does not require percent-encoding.
Related to percent-encoding, if the driver does not require percent-encoding, specify whether authMechanismProperties values with commas must be passed in through the MongoCredential object rather than the connection string, also based on the PyMongo driver ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
C: Looks like this is in progress so you may not need to change it now but keep it in mind.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for bringing this up. Confirmed that the C# driver supports both ways. I'm going to remove "percent-encoded" language to simplify things for users.
.. tab:: Connection String | ||
:tabid: mongodb-gcp-imds-connection-string | ||
|
||
The following code example shows how to specify GCP IMDS OIDC authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
S: Clarify that this is using the Connection String.
The following code example shows how to specify GCP IMDS OIDC authentication. | |
The following code example shows how to specify GCP IMDS OIDC authentication as part of the connection string. |
.. tab:: MongoCredential | ||
:tabid: mongodb-gcp-mongo-credential | ||
|
||
The following code example shows how to specify GCP IMDS OIDC authentication. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following code example shows how to specify GCP IMDS OIDC authentication. | |
The following code example shows how to specify GCP IMDS OIDC authentication by using a ``MongoCredential`` object. |
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-39359
Staging - https://preview-mongodbmongokart.gatsbyjs.io/csharp/docsp-39359-oidc-gcp/fundamentals/enterprise-authentication/#gcp-imds
Self-Review Checklist