Skip to content

Conversation

mongoKart
Copy link
Collaborator

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-39359
Staging - https://preview-mongodbmongokart.gatsbyjs.io/csharp/docsp-39359-oidc-gcp/fundamentals/enterprise-authentication/#gcp-imds

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@shuangela shuangela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, a couple of small suggestions/comments.

:tabid: mongodb-gcp-imds-connection-string

The following code example shows how to specify GCP IMDS OIDC authentication.
Replace the ``<percent-encoded audience>`` placeholder with the percent-encoded
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: Does the audience have to be percent-encoded? The PyMongo driver currently does not require percent-encoding for the audience value so it would be great to clarify whether this driver also does not require percent-encoding.

Related to percent-encoding, if the driver does not require percent-encoding, specify whether authMechanismProperties values with commas must be passed in through the MongoCredential object rather than the connection string, also based on the PyMongo driver ticket.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

C: Looks like this is in progress so you may not need to change it now but keep it in mind.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for bringing this up. Confirmed that the C# driver supports both ways. I'm going to remove "percent-encoded" language to simplify things for users.

.. tab:: Connection String
:tabid: mongodb-gcp-imds-connection-string

The following code example shows how to specify GCP IMDS OIDC authentication.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S: Clarify that this is using the Connection String.

Suggested change
The following code example shows how to specify GCP IMDS OIDC authentication.
The following code example shows how to specify GCP IMDS OIDC authentication as part of the connection string.

.. tab:: MongoCredential
:tabid: mongodb-gcp-mongo-credential

The following code example shows how to specify GCP IMDS OIDC authentication.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following code example shows how to specify GCP IMDS OIDC authentication.
The following code example shows how to specify GCP IMDS OIDC authentication by using a ``MongoCredential`` object.

@mongoKart mongoKart merged commit e456f4f into mongodb:master Jun 12, 2024
@mongoKart mongoKart deleted the docsp-39359-oidc-gcp branch June 12, 2024 20:12
mongoKart added a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants