Skip to content

Conversation

mcmorisi
Copy link
Collaborator

@mcmorisi mcmorisi commented Jun 7, 2024

Pull Request Info

Pardon the long line with the vector definition, the example is taken directly from the Atlas manual.

PR Reviewing Guidelines

JIRA - DOCSP-33408
Staging -

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Really nice job. A few suggestions and small things to clarify

@mcmorisi mcmorisi requested a review from BorisDog June 7, 2024 19:07
public double[] Embedding { get; set; }
}

The following example shows how to use LINQ to generate a ``$vectorSearch`` stage to search
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really LINQ. It's just IMongoQueryable is the entry point for VectorSearch stage, as well as for LINQ expressions. But the next Select statement is part of LINQ..

]
}

$vectorSearch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part looks good.
VectorSearch is not only limited to IMongoQueryable. We also have builders and Fluent API options. I think it's worth documenting all options.

Also should we have a separate page for VectorSearch (like we do for AtlasSearch) to increase visibility? cc @rishitb-mongodb?

Copy link
Collaborator Author

@mcmorisi mcmorisi Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was curious about this point and would like to hear Rishit's PoV – I originally didn't add documentation to the Builders page we have since it didn't seem that there was a specific builder for the VectorSearch stage (i.e. nothing like a Builders.VectorSearch) like there is for the other stages on that page (e.g. Project, Sort)

I'd also want to be wary of duplicating information – there is ample documentation on Vector Search in Atlas already so I'd prefer to link to that when able, unless there are C# driver-specific quirks that are worth calling out.

Copy link
Collaborator Author

@mcmorisi mcmorisi Jun 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess I'm struggling with the "natural" place to describe Vector Search in our docs since it seems like neither Builders nor LINQ is fully appropriate. The two options that make the most sense to me are either a new section in the Aggregations page which briefly touches on Vector Search, or a brand new page (as you mentioend). Seconding your request to @rishitb-mongodb for feedback.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to have some sort of consistency, either within our documentation (by having a dedicated page for Atlas Vector Search just like we do for Atlas Search) OR with other driver's documentation (which is what the above approach does by mimicing what the Java driver was doing for Atlas Vector Search). I know there is a standardization effort coming soon for this. I didn't know that we have Builders and FluentAPI option for Vector Search as well. If this is the case then I agree this page shouldn't be under LINQ. If a developer can do Vector Search using Builders, Fluent API or LINQ then we should have a dedicated page for it but we don't need to repeat everything in the main Atlas documentation, just redirect to it wherever needed.

@mcmorisi mcmorisi requested review from BorisDog and mongoKart June 10, 2024 20:02
Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcmorisi mcmorisi merged commit dd7d7e6 into mongodb:master Jun 14, 2024
mcmorisi added a commit that referenced this pull request Jun 14, 2024
mcmorisi added a commit that referenced this pull request Jun 14, 2024
mcmorisi added a commit that referenced this pull request Jun 14, 2024
mcmorisi added a commit that referenced this pull request Jun 14, 2024
@mcmorisi mcmorisi deleted the DOCSP-33408-vectorsearch branch June 14, 2024 16:33
mcmorisi added a commit that referenced this pull request Jun 14, 2024
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants