-
Notifications
You must be signed in to change notification settings - Fork 26
DOCSP-38680: v2.25 updates #183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM w/ 1 fix and a couple of suggestions
source/whats-new.txt
Outdated
What's New in 2.25 | ||
------------------ | ||
|
||
The 2.24 driver release includes the following new features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 2.24 driver release includes the following new features: | |
The 2.25 driver release includes the following new features: |
- .NET 4.8 | ||
- .NET 4.7 [#2.14-note]_ | ||
- .NET 4.6 | ||
* - 2.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Condense rows 2.20 through 2.25 to a single row, similar to Go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like 2.14 through 2.25 are the same, so I'll do it for those.
- MongoDB 3.2 | ||
- MongoDB 3.0 | ||
- MongoDB 2.6 | ||
* - 2.25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: Condense rows 2.14 through 2.25 to a single row, similar to Go.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like only 2.20 through 2.25 are similar, so I'll do it for those.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor comment
- Added support for overriding the ``"mongodb"`` service name with a custom one | ||
by using the ``srvServiceName`` connection option. | ||
- Fixed behavior in which bulk write operations enumerated the requests | ||
parameter more than once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think 'Improved' instead of 'fixed' is better, as it technically it was not wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* DOCSP-38680: v2.25 updates
Pull Request Info
PR Reviewing Guidelines
JIRA - https://jira.mongodb.org/browse/DOCSP-38680
Staging:
Self-Review Checklist