Skip to content

Conversation

ccho-mongodb
Copy link
Contributor

@ccho-mongodb ccho-mongodb commented Apr 17, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-38680
Staging:

Self-Review Checklist

  • Is this free of any warnings or errors in the RST?
  • Did you run a spell-check?
  • Did you run a grammar-check?
  • Are all the links working?
  • Are the facets and meta keywords accurate?

Copy link
Collaborator

@mongoKart mongoKart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ 1 fix and a couple of suggestions

What's New in 2.25
------------------

The 2.24 driver release includes the following new features:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The 2.24 driver release includes the following new features:
The 2.25 driver release includes the following new features:

- .NET 4.8
- .NET 4.7 [#2.14-note]_
- .NET 4.6
* - 2.25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Condense rows 2.20 through 2.25 to a single row, similar to Go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like 2.14 through 2.25 are the same, so I'll do it for those.

- MongoDB 3.2
- MongoDB 3.0
- MongoDB 2.6
* - 2.25
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: Condense rows 2.14 through 2.25 to a single row, similar to Go.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like only 2.20 through 2.25 are similar, so I'll do it for those.

Copy link
Collaborator

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment

- Added support for overriding the ``"mongodb"`` service name with a custom one
by using the ``srvServiceName`` connection option.
- Fixed behavior in which bulk write operations enumerated the requests
parameter more than once.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 'Improved' instead of 'fixed' is better, as it technically it was not wrong.

Copy link
Collaborator

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ccho-mongodb ccho-mongodb merged commit 5c4516c into mongodb:master Apr 17, 2024
@ccho-mongodb ccho-mongodb deleted the DOCSP-38680-v2.25 branch April 17, 2024 20:01
mongoKart pushed a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
* DOCSP-38680: v2.25 updates
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants