Direct query lookup tests #426
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WaVEV
force-pushed
the
direct-query-lookup-tests
branch
4 times, most recently
from
9bf4025 to
804b0c0
Compare
timgraham
reviewed
Oct 27, 2025
tests/lookup_/tests.py
Outdated
Comment on lines
103
to
149
| def test_union_simple_conditions(self): | ||
| with self.assertNumQueries(1) as ctx: | ||
| list(Book.objects.filter(title="star wars").union(Book.objects.filter(isbn__in="1234"))) | ||
| self.assertAggregateQuery( | ||
| ctx.captured_queries[0]["sql"], | ||
| "lookup__book", | ||
| [ | ||
| {"$match": {"title": "star wars"}}, | ||
| {"$project": {"_id": 1, "title": 1, "isbn": 1}}, | ||
| { | ||
| "$unionWith": { | ||
| "coll": "lookup__book", | ||
| "pipeline": [ | ||
| {"$match": {"isbn": {"$in": ("1", "2", "3", "4")}}}, | ||
| {"$project": {"_id": 1, "title": 1, "isbn": 1}}, | ||
| ], | ||
| } | ||
| }, | ||
| {"$group": {"_id": {"_id": "$_id", "title": "$title", "isbn": "$isbn"}}}, | ||
| {"$addFields": {"_id": "$_id._id", "title": "$_id.title", "isbn": "$_id.isbn"}}, | ||
| ], | ||
| ) | ||
|
|
||
| def test_union_all_simple_conditions(self): | ||
| with self.assertNumQueries(1) as ctx: | ||
| list( | ||
| Book.objects.filter(title="star wars").union( | ||
| Book.objects.filter(isbn="1234"), all=True | ||
| ) | ||
| ) | ||
| self.assertAggregateQuery( | ||
| ctx.captured_queries[0]["sql"], | ||
| "lookup__book", | ||
| [ | ||
| {"$match": {"title": "star wars"}}, | ||
| {"$project": {"_id": 1, "title": 1, "isbn": 1}}, | ||
| { | ||
| "$unionWith": { | ||
| "coll": "lookup__book", | ||
| "pipeline": [ | ||
| {"$match": {"isbn": "1234"}}, | ||
| {"$project": {"_id": 1, "title": 1, "isbn": 1}}, | ||
| ], | ||
| } | ||
| }, | ||
| ], | ||
| ) |
Collaborator
There was a problem hiding this comment.
I moved these to queries_/test_qs_combinators.py to match the location of Django's tests for union(). Similarly, test_subquery_filter_constant may be more complicated than most lookup tests.
WaVEV
force-pushed
the
direct-query-lookup-tests
branch
from
804b0c0 to
6ee279f
Compare
WaVEV
force-pushed
the
direct-query-lookup-tests
branch
from
6ee279f to
1c6e93d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the test coverage for query refactor (#396).