REP-6634 Add time-series support #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdq45gj
approved these changes
Sep 22, 2025
| switch srcSpec.Type { | ||
| case "collection": | ||
| canCompareData = true | ||
| case "view": |
There was a problem hiding this comment.
nit: would prefer canCompareData being set to false explicitly.
| ) | ||
|
|
||
| // TestTimeSeries_BucketsOnly confirms the verifier’s time-series coverage | ||
| // when only the buckets exist. This is important when verifying shard-to-shard. |
There was a problem hiding this comment.
This is important when verifying shard-to-shard.
Do we test shard-to-shard? Just curious.
There was a problem hiding this comment.
Shard-to-shard verification has been tested, yeah. Nothing is automated, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changeset adds basic time-series support.
Because of the verifier’s
_iddependency, this verifies buckets rather than logical measurements. This implies a requirement that the migration copy time-series collections via buckets as well since a logical replication would not preserve artifacts like bucket_id, and possibly not even the grouping of measurements.Because of the bucket-level verification, details in mismatch reports are not very useful for time-series because they reference bucket-level fields that the logical API doesn’t expose.
This works with per-shard verification (i.e., it can verify with or without a view). It does not currently support namespace filtering.