feat: Supports dynamic blocks in tags and labels #31
Conversation
lantoli
changed the title
* main: chore: Updates Go to 1.24.1 and linter (#32)
internal/convert/convert.go
Outdated
| return nil, fmt.Errorf("dynamic block %s: %s or %s not found", name, nKey, nValue) | ||
| } | ||
| collectionExpr := strings.TrimSpace(string(d.forEach.Expr().BuildTokens(nil).Bytes())) | ||
| keyExpr := strings.TrimSpace(strings.ReplaceAll(string(key.Expr().BuildTokens(nil).Bytes()), |
There was a problem hiding this comment.
A lot happening on this line. Maybe create an intermediate variable?
Or
Extract this into a function. for example, removeDynamicVarPrefx()
There was a problem hiding this comment.
thanks, changed here: 24b5389
| } | ||
| return nil | ||
| } | ||
|
|
||
| type dynamicBlock struct { |
| priority = 7 | ||
| } | ||
| } | ||
| labels { |
There was a problem hiding this comment.
Wow. Quite a big example! Static values and dynamic!!
| tags { | ||
| key = var.tag_key # non-literal values are supported and enclosed in parentheses | ||
| value = var.tag_value | ||
| } | ||
| dynamic "tags" { | ||
| for_each = var.tags | ||
| content { | ||
| key = tags.key | ||
| value = replace(tags.value, "/", "_") | ||
| } | ||
| } |
There was a problem hiding this comment.
nice that we support the possibility of dynamic + literal blocks at the same time
| ] | ||
| } | ||
| ] | ||
| tags = var.tags |
There was a problem hiding this comment.
are we assuming that var.tags is map here? Is there a case where it could be a list?
There was a problem hiding this comment.
all examples I've found are maps, if you find any example of a list, please let me know
There was a problem hiding this comment.
Makes sense, I believe it will good to keep track of these assumptions mainly for our future reference and transparency for users. Maybe a small note within Dynamic blocks in tags and labels section in the readme file?
There was a problem hiding this comment.
thanks @AgustinBettati , added in this follow-up PR: #33
@AgustinBettati I think we'll be able to do some reuse, for example the dynamicBlock struct and surely some funcs |
Description
Supports dynamic blocks
Link to any related issue(s): CLOUDP-303941
Type of change:
Required Checklist:
Further comments