feat: Converts data sources #24
Conversation
internal/convert/convert.go
Outdated
| for _, resource := range parser.Body().Blocks() { | ||
| labels := resource.Labels() | ||
| resourceName := labels[0] | ||
| if resource.Type() != resourceType || resourceName != cluster { | ||
| continue | ||
| } | ||
| resourceb := resource.Body() | ||
| if errDyn := checkDynamicBlock(resourceb); errDyn != nil { | ||
| return nil, errDyn | ||
| } | ||
| labels[0] = advCluster | ||
| resource.SetLabels(labels) | ||
|
|
||
| if resourceb.FirstMatchingBlock(nRepSpecs, nil) != nil { | ||
| err = fillCluster(resourceb) | ||
| } else { | ||
| err = fillFreeTierCluster(resourceb) | ||
| } | ||
| converted, err := convertResource(resource) |
There was a problem hiding this comment.
nit: the resource variable name confused me here, this would be a block which can be a resource or data source right?
There was a problem hiding this comment.
thanks, changed here: b1d2a2b
| data "mongodbatlas_advanced_cluster" "singular" { | ||
| # data source content is kep, only data source type is changed - singular | ||
| project_id = mongodbatlas_advanced_cluster.example.project_id | ||
| name = mongodbatlas_advanced_cluster.example.name | ||
| depends_on = [mongodbatlas_privatelink_endpoint_service.example_endpoint] | ||
|
|
||
| # Generated by atlas-cli-plugin-terraform. | ||
| # Please confirm that all references to this resource are updated. | ||
| } |
There was a problem hiding this comment.
should we include use_replication_spec_per_shard = true? Might be the most consistent output given we generated advanced_cluster resources with single replication spec per shard (no use of num_shards).
There was a problem hiding this comment.
yes we should because eventually in 2.0 use_replication_spec_per_shard = true becomes the standard, right?
There was a problem hiding this comment.
correct, added this into the v2 release doc as well
There was a problem hiding this comment.
great point, added here: 9297c5f
| project_id = mongodbatlas_advanced_cluster.example.project_id | ||
| name = mongodbatlas_advanced_cluster.example.name | ||
| depends_on = [mongodbatlas_privatelink_endpoint_service.example_endpoint] | ||
| use_replication_spec_per_shard = true |
There was a problem hiding this comment.
Nice to use the new format 👍
Description
Converts data sources
Link to any related issue(s): CLOUDP-301789
Type of change:
Required Checklist:
Further comments