fix(mongodb-constants): fix regexp that picks valid part of semver version #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gribnoysup
force-pushed
the
fix-version-regex
branch
from
b30752c to
78a6876
Compare
lerouxb
approved these changes
Sep 21, 2023
addaleax
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex that we used to clean up current server version was only picking up a single number from the patch version because of the unnecessary
?usage. Seems like we had this bug for awhile now, even before we moved all this logic to this package, just never noticed or got reports before, I noticed this only now when testing$vectorSearchstageAlso @mcasimir asked to add tests for version as we specify it in constants, added it in the same patch as a drive-by