chore: Clean up CacheHeaderInterceptor
#33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvcache
reviewed
Apr 7, 2022
src/grpc/cache_header_interceptor.rs
Outdated
| fn call( | ||
| &mut self, | ||
| mut request: tonic::Request<()>, | ||
| ) -> Result<tonic::Request<()>, tonic::Status> { | ||
| let request_metadata = request.metadata().clone(); |
There was a problem hiding this comment.
do we even need this clone anymore?
There was a problem hiding this comment.
It seems that let cache_name = request.metadata().get("cahce").unwrap() is immutable borrow; therefore request cannot be called with metadata_mut().insert() after that call.
So I think we need to clone first and get cache metadata.
src/grpc/cache_header_interceptor.rs
Outdated
| "content-type", | ||
| tonic::metadata::AsciiMetadataValue::from_str("application/grpc").unwrap(), | ||
| ); | ||
|
|
||
| let cache_name = request_metadata.get("cache").unwrap(); | ||
|
|
||
| // need to re-add our `cache` header back into the interceptor or it will be stripped out |
There was a problem hiding this comment.
Good catch! Since we updated to use mutable request directly, it does not seem necessary to add cache back to metadata, which also solve the above comment.
I can just remove this and the above altogether.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
requestarg mutable forCacheHeaderInterceptorso that we don't need to create a new request.Related conversations: #31 (comment)