-
Notifications
You must be signed in to change notification settings - Fork 111
JEP 512 Support #484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
JEP 512 Support #484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@cayhorstmann please look at CI output, please try to build project locally and check if some files was updated |
Contributor
Author
|
I looked at the two failures, mexec-29-non-static, and mexec-98. They should no longer fail with JEP 512. I removed them. |
slawekjaranowski
approved these changes
Aug 26, 2025
slachiewicz
approved these changes
Sep 14, 2025
dongjoon-hyun
added a commit
to apache/spark
that referenced
this pull request
Oct 15, 2025
### What changes were proposed in this pull request? This PR aims to make `Maven` plugins up-to-date as a part of Apache Spark 4.1.0 preparation. ### Why are the changes needed? To bring the latest bug fixes and improvements. - exec-maven-plugin - https://github.com/mojohaus/exec-maven-plugin/releases/tag/3.6.1 - https://github.com/mojohaus/exec-maven-plugin/releases/tag/3.6.0 - mojohaus/exec-maven-plugin#484 - maven-compiler-plugin - https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.14.1 - maven-enforcer-plugin - https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.2 - https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.1 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #52622 from dongjoon-hyun/SPARK-53919. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
huangxiaopingRD
pushed a commit
to huangxiaopingRD/spark
that referenced
this pull request
Nov 25, 2025
### What changes were proposed in this pull request? This PR aims to make `Maven` plugins up-to-date as a part of Apache Spark 4.1.0 preparation. ### Why are the changes needed? To bring the latest bug fixes and improvements. - exec-maven-plugin - https://github.com/mojohaus/exec-maven-plugin/releases/tag/3.6.1 - https://github.com/mojohaus/exec-maven-plugin/releases/tag/3.6.0 - mojohaus/exec-maven-plugin#484 - maven-compiler-plugin - https://github.com/apache/maven-compiler-plugin/releases/tag/maven-compiler-plugin-3.14.1 - maven-enforcer-plugin - https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.2 - https://github.com/apache/maven-enforcer/releases/tag/enforcer-3.6.1 ### Does this PR introduce _any_ user-facing change? No behavior change. ### How was this patch tested? Pass the CIs. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#52622 from dongjoon-hyun/SPARK-53919. Authored-by: Dongjoon Hyun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds support for JEP 512. A program can be launched by
static void main(String[] args), instancevoid main(String[] args),static void main(), or instancevoid main(). The classicextends Runnablestill works.As implemented, this works for all versions of Java. There is the slight risk of backwards incompatibility. Perhaps it would be desirable to only allow the new forms when the Java version is ≥ 25, or the user sets an attribute in the POM file requesting it?