fix!: fix serde support for non self-describing formats #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rinde
requested review from
Felerius,
fabian-braun,
jankeu,
lxwbr and
urmaul
as code owners
urmaul
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our de-serialization code for
TimeandDurationwas supporting several different formats that our serialization code didn't support. One downside of this approach is that it only supported self-describing formats (e.g. json) and it didn't support non self-describing formats (e.g. bincode).This PR fixes that by removing the support to deserialize from different formats from within the deserializer, but it keeps the support to do so (e.g. RFC 3339). For example, custom (de)serialization can still be used with serde by utilizing serde functionality such as serialize_with.
This PR simplifies the serde code and adds tests for both json and bincode for all types.