perf: remove live binding from cjs builds #3701
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reduce payload size caused by live bindings boilerplate
This pull request involves several updates to the Rollup configuration files across different packages. The primary change is the addition of the
externalLiveBindings: false
property for CommonJS (CJS) format outputs. Additionally, there are some refactorings in theruntime-tools
package to improve code clarity and maintainability.Key changes include:
Addition of
externalLiveBindings: false
for CJS formatpackages/error-codes/rollup.config.js
: AddedexternalLiveBindings: false
for CJS format outputs. [1] [2]packages/runtime-core/rollup.config.cjs
: AddedexternalLiveBindings: false
for CJS format outputs. [1] [2]packages/runtime-plugins/inject-external-runtime-core-plugin/rollup.config.cjs
: AddedexternalLiveBindings: false
for CJS format outputs. [1] [2]Refactoring in
runtime-tools
packagepackages/runtime-tools/rollup.config.cjs
: Changed the function definition from an arrow function to a regular function and refactored the handling ofoutputConfig
to improve readability and maintainability. [1] [2] [3] [4]Related Issue
Types of changes
Checklist