Skip to content

perf: remove live binding from cjs builds #3701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 16, 2025
Merged

Conversation

ScriptedAlchemy
Copy link
Member

@ScriptedAlchemy ScriptedAlchemy commented Apr 15, 2025

Description

Reduce payload size caused by live bindings boilerplate

This pull request involves several updates to the Rollup configuration files across different packages. The primary change is the addition of the externalLiveBindings: false property for CommonJS (CJS) format outputs. Additionally, there are some refactorings in the runtime-tools package to improve code clarity and maintainability.

Key changes include:

Addition of externalLiveBindings: false for CJS format

Refactoring in runtime-tools package

Related Issue

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have updated the documentation.

Copy link

changeset-bot bot commented Apr 15, 2025

⚠️ No Changeset found

Latest commit: a0a5e3b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

netlify bot commented Apr 15, 2025

Deploy Preview for module-federation-docs ready!

Name Link
🔨 Latest commit 8448987
🔍 Latest deploy log https://app.netlify.com/sites/module-federation-docs/deploys/67ff4a261fb6d50009f311ab
😎 Deploy Preview https://deploy-preview-3701--module-federation-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ScriptedAlchemy ScriptedAlchemy marked this pull request as ready for review April 15, 2025 22:56
@ScriptedAlchemy ScriptedAlchemy requested a review from 2heal1 April 16, 2025 00:54
@ScriptedAlchemy ScriptedAlchemy changed the title Perf/live bindings perf: remove live binding from cjs builds Apr 16, 2025
@ScriptedAlchemy ScriptedAlchemy merged commit 38f324f into main Apr 16, 2025
16 checks passed
@ScriptedAlchemy ScriptedAlchemy deleted the perf/live-bindings branch April 16, 2025 07:09
@2heal1 2heal1 mentioned this pull request Apr 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants