refactor(bridge-react): Refactor the bridge-react to better support multiple React versions from React 16 to React 19 #3690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith enhanced createRoot options
…m/module-federation/core into feat/react-bridge-compat-reactv19
…reateBridgeComponent
🦋 Changeset detectedLatest commit: 1ecdeba The changes in this PR will be included in the next version bump. This PR includes changesets to release 32 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
KyrieLii
reviewed
Apr 15, 2025
| You can choose specific import paths based on the React version used in your project: | ||
|
|
||
| ```jsx | ||
| // Auto-detect React version (recommended for most scenarios) |
There was a problem hiding this comment.
How to detect, I'm not found the logic.(maybe just not in this diff)
There was a problem hiding this comment.
KyrieLii
reviewed
Apr 15, 2025
| * - import { createBridgeComponent } from '@module-federation/bridge-react/v18' | ||
| * - import { createBridgeComponent } from '@module-federation/bridge-react/v19' | ||
| */ | ||
| function defaultCreateRoot( |
KyrieLii
approved these changes
Apr 15, 2025
2heal1
reviewed
Apr 16, 2025
| :::danger | ||
| 请注意：使用 `@module-federation/bridge-react` 后不能将 `react-router-dom` 设置成 shared，否则构建工具将会提示异常。这是因为 `@module-federation/bridge-react` 通过代理 `react-router-dom` 实现了对路由的控制，以保证应用间路由能够正常协同工作。 | ||
| :::danger 注意 | ||
| 使用 `@module-federation/bridge-react` 后不能将 `react-router-dom` 设置成 shared，否则构建工具将会提示异常。这是因为 `@module-federation/bridge-react` 通过代理 `react-router-dom` 实现了对路由的控制，以保证应用间路由能够正常协同工作。 |
There was a problem hiding this comment.
Can we auto detect it on build plugin ?
2heal1
reviewed
Apr 16, 2025
| } | ||
|
|
||
| // For React 16/17, use legacy API | ||
| return { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
refactor(bridge-react): Refactor the bridge-react to better support multiple React versions from React 16 to React 19, in the meantime maintaining backward compatibility and providing clearer version-specific entry points.
Related Issue
Types of changes
Checklist