Apply same patch with Ron and Goff #4572
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AHaumer
added
enhancement
maltelenz
approved these changes
Mar 6, 2025
Contributor
maltelenz
left a comment
maltelenz
left a comment
There was a problem hiding this comment.
I ran it in WSM on one platform, and quantitatively the results look similar to the (old) reference, but of course they differ in the details. The largest change was in capacitor.v:
Approving with the usual caveat that I have no understanding of the model.
Esther-Devakirubai
pushed a commit
that referenced
this pull request
Mar 10, 2025
Contributor
|
Backported by #4579 |
casella
pushed a commit
that referenced
this pull request
Mar 10, 2025
Co-authored-by: Anton Haumer <[email protected]>
beutlich
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If @casella agrees after testing with OM and @maltelenz agrees after testing with WSM, we should get this into 4.1.0
(means @Esther-Devakirubai please backport to 4.1.x and @GallLeo @MatthiasBSchaefer please re-generate reference results).
This would help to achieve more stability for 4.1.0.