Skip to content

Conversation

@beutlich
Copy link
Member

@beutlich beutlich commented Jan 10, 2024

The ResolvedGitHubIssues documents are created from my branch fix-release-notes-generation (while Modelica/Resources/Documentation/Generate-ReleaseNotes.py is broken and #3999 still is open). No need to merge them now, since they should be updated immediately before tagging.

@beutlich beutlich added L: Resources Issue addresses Modelica/Resources (excl. C-Sources) L: UsersGuide Issue addresses Modelica.UsersGuide labels Jan 10, 2024
@beutlich beutlich requested review from AHaumer and casella January 10, 2024 21:09
@beutlich beutlich added the documentation Issue addresses the documentation label Jan 10, 2024
@beutlich beutlich added this to the MSL4.1.0 milestone Jan 10, 2024
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@casella
Copy link
Contributor

casella commented Jan 16, 2024

Thanks @beutlich! Two questions:

  • does this PR replace Fix release notes generation #3999 as a backup in case we can't fix the Python script
  • should we merge for the tagging of the alpha.1 version and then update with beta and rc versions?

Adding @arunkumar-narasimhan and @Harisankar-Allimangalath to the loop.

@beutlich
Copy link
Member Author

@casella We have/had multiple kind of release notes:

  1. This PR (and its follow-up issue Edit Modelica.UsersGuide.ReleaseNotes.Version_4_1_0 #4260) care about the manually edited release notes.
  2. PR Fix release notes generation #3999 is about the resolved GitHub issues. Which is nice to have (once all issues/PRs are properly labeled). Thus, it does not replace the manual editing of release notes.
  3. There also is the pretty useful MSL version comparison (which can be another source of input for the manual editing).

@arunkumar-narasimhan
Copy link
Collaborator

@casella, @beutlich, My understanding is that #4251 and #3999 are independent PRs, so we should review and merge #4251 and then #4247 to proceed with branching while working on #3999.

if so, could you please review this PR @casella?

@beutlich beutlich force-pushed the create_Version_4_1_0 branch from 5bb6b81 to 84f1e6e Compare January 18, 2024 06:39
@Harisankar-Allimangalath
Copy link
Contributor

@beutlich from your understanding also this PR is independent of #3999 right , so once we get this approval , we can proceed with branching while working on #3999 right ?

@beutlich beutlich force-pushed the create_Version_4_1_0 branch from 105a74e to b0f505e Compare January 18, 2024 20:56
@beutlich beutlich removed the request for review from casella January 19, 2024 06:45
@beutlich beutlich merged commit 8753b87 into modelica:master Jan 19, 2024
@beutlich beutlich deleted the create_Version_4_1_0 branch January 19, 2024 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Issue addresses the documentation L: Resources Issue addresses Modelica/Resources (excl. C-Sources) L: UsersGuide Issue addresses Modelica.UsersGuide

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants