Skip to content

Conversation

@AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Dec 14, 2022

Fixes #4065 - thanks @ErikHenningsson for pointing that out.
For now, I kept the old formulation as documentation //
Well it's an enhancement, not really a bugfix.
@dietmarw should that get back-ported?

@AHaumer AHaumer added enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks labels Dec 14, 2022
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@dietmarw dietmarw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AHaumer I don't see this as a bug (nothing was broken before) but simply a numerical enhancement. So backporting would be overkill if you ask me.

@dietmarw dietmarw requested a review from HansOlsson December 15, 2022 07:43
@dietmarw dietmarw added this to the MSL4.1.0 milestone Dec 15, 2022
Copy link
Contributor

@HansOlsson HansOlsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

@MartinOtter MartinOtter merged commit 89d5175 into modelica:master Dec 16, 2022
@beutlich beutlich changed the title Replaced state events by time events Replace state events by time events Aug 28, 2024
@AHaumer AHaumer deleted the SourceEvents branch April 19, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or enhancement L: Blocks Issue addresses Modelica.Blocks

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unnecessary potential state events in Modelica.Blocks.Sources.Pulse

4 participants