Fix reading file with EOL=LF on Windows #3669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beutlich
added
bug
beutlich
force-pushed
the
fix-eol-read
branch
3 times, most recently
from
e8a412e to
6b26876
Compare
sjoelund
reviewed
Nov 18, 2020
Member
sjoelund
left a comment
sjoelund
left a comment
There was a problem hiding this comment.
I don't have a Windows machine to test this on and as far as I can see, the mingw test only compiles the code and does not run tests. Perhaps we should run this through wine or something in the future.
beutlich
force-pushed
the
fix-eol-read
branch
from
6b26876 to
ec5fe03
Compare
Member
Author
|
I tested and debugged locally on my Win machine. I hope that @HansOlsson can also test on Win. |
sjoelund
approved these changes
Nov 18, 2020
beutlich
requested review from
HansOlsson
and removed request for
HansOlsson
HansOlsson
approved these changes
Dec 2, 2020
Contributor
HansOlsson
left a comment
HansOlsson
left a comment
There was a problem hiding this comment.
Seems to build on Windows, and the test-case triggering the original issue worked;
so it looks good.
This was referenced Dec 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR superseds #3631 and fixes reading of text files with EOL=LF on Windows. It also adds unit tests for these functions.
I decided to duplicate the code of function
readLine(from ModelicaIO) since we have no concept how to deal with utility functions that are shared between different C libraries. (I also did so once in the past by duplicating functiontransposebetween ModelicaIO and ModelicaStandardTables C libraries.)