fix: normalize headers in sse transport #856
Open
+53
−32
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SSE transport does not properly forward custom headers that are provided as a
Headers
object or as a[string, string][]
.The Streamable HTTP transport already implements the correct solution to this problem, so I moved the solution into a common helper function, used it from both transports, and added a test to the SSE transport that exercises this.
Motivation and Context
Bug
How Has This Been Tested?
I have an internal application that passes custom headers
[["Authorization", "Bearer XYZ"]]
to the client. Before this change, this was getting forwarded to the server as a header{0: "Authorization,Bearer XYZ"}
. After this change, it is correctly forwarded as{Authorization: "Bearer XYZ"}
.Also, I added a unit test.
Breaking Changes
None
Types of changes
Checklist
Additional context
None