fix: pass fetchfn parameter to registerClient and refreshAuthorizatio… #850
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed missing
fetchFn
parameter inregisterClient
andrefreshAuthorization
function calls in the auth flowMotivation and Context
The
authInternal
function accepts afetchFn
parameter and correctly passes it to most HTTP calls (discoverOAuthProtectedResourceMetadata
,discoverAuthorizationServerMetadata
,exchangeAuthorization
), but was missing it in calls toregisterClient
andrefreshAuthorization
. This caused these functions to fall back to the globalfetch
instead of using any customfetchFn
provided, creating inconsistent behavior in scenarios requiring custom network configurations, testing with mock fetch functions, or environments where global fetch might not be available.How Has This Been Tested?
Tested in our application at Smithery (https://smithery.ai)
Types of changes
Checklist
Additional context