feat: add optional instructions field to server _oninitialize #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jspahrsummers
requested changes
Jan 13, 2025
src/server/index.ts
Outdated
Comment on lines
266
to
268
| private getInstructions(): string | undefined { | ||
| return this._instructions; | ||
| } |
There was a problem hiding this comment.
Can we please remove this? I don't think there's any benefit to a private getter in this case.
There was a problem hiding this comment.
Yes, removed and updated!
|
@kalvinnchau I don't see a way in which clients can get hold of the instructions during connect or at any other point. |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the optional
instructionsfield to the server per the mcp specMotivation and Context
Allows setting up initial server instructions
How Has This Been Tested?
Updated the test in
src/server/index.test.tsto verify theinstructionfield is setBreaking Changes
None
Types of changes
Checklist
Additional context