refactor: merge cached_schema_for_type into schema_for_type #581
+91
−30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Following @alexhancock's suggestion in #566 (comment) to consolidate caching logic into the primary public method, this PR applies the same refactoring pattern to
schema_for_typeandcached_schema_for_type.Previously, we had two public functions serving the same purpose:
schema_for_type<T>() -> JsonObject- no cachingcached_schema_for_type<T>() -> Arc<JsonObject>- with cachingThis duplication can create confusion about which to use and led to inefficient Arc-to-JsonObject-to-Arc conversions. Following the pattern established in #566, caching is now an internal optimization detail, not part of the public API.
How Has This Been Tested?
Added a few new unit tests
Breaking Changes
Functionality remains the same with improved performance.
Types of changes
Checklist
Additional context