Add an axum sse example #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds supporting modules for the Axum Server-Sent Events (SSE) example: - Added `counter.rs` with a simple counter router implementation - Added `jsonrpc_frame_codec.rs` for decoding JSON-RPC frames - Created a `mod.rs` to expose these modules - Removed the previous SSE example configuration from Cargo.toml
Contributor
|
Hi! Thank you for the contribution!! We recently overhauled the examples in #10, can you please update this PR to follow that one? |
kalvinnchau
previously approved these changes
Mar 4, 2025
Contributor
kalvinnchau
left a comment
kalvinnchau
left a comment
There was a problem hiding this comment.
lgtm! thanks for the contribution!
kalvinnchau
approved these changes
Mar 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an axum sse server example for crate
mcp-serverMotivation and Context
Since there's a stdin example, I want to add a sse example as a complement.
How Has This Been Tested?
Run
npx @modelcontextprotocol/inspectorand connect tolocalhost:8000/sse, everything seems OK.Breaking Changes
No breaking changes
Types of changes
Checklist
Additional context
Some changes are made in
crates/mcp-server/src/lib.rsto makeserver.run(transport)Send, so async runtime like tokio can spawn it.