Rename to MCP when handling exceptions in Streamable HTTP transport
#62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason for the change is that a NameError occurs when a POST request is made while the stream is closed because ModelContextProtocol is undefined. I have also added test cases to check the behaviour when IOError and Errno::EPIPE occurs.
atesgoral
approved these changes
Jun 15, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
The reason for the change is that a NameError occurs when a POST request is made while the stream is closed because ModelContextProtocol is undefined.
How Has This Been Tested?
A NameError does not occur when a POST request is made while the stream is closed using the sample code from 'examples/streaming_http_test_server.rb' file.
Breaking Changes
There is no need. Streamable HTTP transport has not been published.
Types of changes
Checklist
Additional context