[Server] Simplify server entrypoint with run-based transport lifecycle #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chr-hertel
reviewed
Oct 8, 2025
| } | ||
|
|
||
| public function connect(TransportInterface $transport): void | ||
| public function run(TransportInterface $transport): mixed |
Member
There was a problem hiding this comment.
which scenarios do we have instead of int?
Contributor
Author
There was a problem hiding this comment.
Check the StreamableHttpTransport and the http examples. For that, It returns a PSR-7 response instead
CodeWithKyrian
force-pushed
the
feat/server-run-transport-lifecycle
branch
from
65cb638 to
c0629f3
Compare
chr-hertel
approved these changes
Oct 10, 2025
chr-hertel
added a commit
to symfony/ai
that referenced
this pull request
Oct 10, 2025
This PR was merged into the main branch. Discussion ---------- [MCP Bundle] Adopt new interface of MCP server | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | Docs? | no | Issues | | License | MIT Follows modelcontextprotocol/php-sdk#103 Commits ------- 6099b4d Adopt new interface of MCP server
bigdevlarry
pushed a commit
to bigdevlarry/php-sdk
that referenced
this pull request
Nov 10, 2025
modelcontextprotocol#103) * feat: replace connect/listen flow with run lifecycle * feat(transport): add phpstan generics for typed transport returns * refactor: standardize variable naming for MCP server instances in transport handling * test: remove unnecessary phpstan-ignore annotation in DocBlockTestFixture
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the old
connect()+listen()flow with a singlerun()method that wires, executes, and tears down transports for every example, doc, and transport implementation.Motivation and Context
connect()andlisten()and worry about cleanup.initialize,onMessage,listen,close) while the server coordinates their use and always closes them oncelisten()finishes...whether that’s a blocking STDIO loop, a one-shot HTTP request, or blocking asynchronous loop.What’s Changed
Server::run()which initializes the transport, hooks up callbacks, runslisten(), closes the transport, and returns whatever the transport returns.0for success,1whenSTDINreading fails) and cleared session state during close.run()and, for STDIO scripts, exit with the returned status.run()instead of invokinglisten()manually.Breaking Changes
Server::connect()has been removed. All consumers must callServer::run($transport)and drop their manual$transport->listen()/$transport->close()calls (if any).